Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compiler warnings on Windows #3844

Merged
merged 4 commits into from
Apr 30, 2024
Merged

fix: compiler warnings on Windows #3844

merged 4 commits into from
Apr 30, 2024

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Apr 30, 2024 •
edited by waynexia
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

Closes #3786

What's changed and what's your intention?

This PR fixes compiler warnings on Windows. It also fixes the test create_metadata_region() on Windows.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 30, 2024
@evenyag evenyag marked this pull request as ready for review April 30, 2024 09:21
@evenyag evenyag requested review from waynexia and a team as code owners April 30, 2024 09:21
@tisonkun tisonkun changed the title fix: fix compiler warnings on Windows fix: compiler warnings on Windows Apr 30, 2024
@tisonkun tisonkun added this pull request to the merge queue Apr 30, 2024
Merged via the queue into GreptimeTeam:main with commit 777bc3b Apr 30, 2024
35 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@tisonkun tisonkun tisonkun approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evenyag @waynexia @tisonkun